Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update documentation to tuono 0.17.x #364

Merged
merged 9 commits into from
Jan 20, 2025
Merged

chore: update documentation to tuono 0.17.x #364

merged 9 commits into from
Jan 20, 2025

Conversation

jacobhq
Copy link
Contributor

@jacobhq jacobhq commented Jan 17, 2025 •
edited
Loading

Context & Description

Fixes #363.

  • update to react 19
  • rename __root file to __layout as per change of 0.17.0
  • some dependencies might need an update to work with react 19
  • Ensure that head content (meta, title, scripts) are working correctly

@github-actions github-actions bot added documentation Improvements or additions to documentation typescript Requires typescript knowledge labels Jan 17, 2025
@jacobhq

This comment was marked as resolved.

Sign in to view
@jacobhq jacobhq marked this pull request as ready for review January 18, 2025 10:51
@jacobhq

This comment was marked as resolved.

Sign in to view
@Valerioageno

This comment was marked as outdated.

Sign in to view
@marcalexiei

This comment was marked as resolved.

Sign in to view
@Valerioageno

This comment was marked as resolved.

Sign in to view
@Valerioageno

This comment was marked as resolved.

Sign in to view
@Valerioageno

This comment was marked as resolved.

Sign in to view
@jacobhq

This comment was marked as resolved.

Sign in to view
@marcalexiei marcalexiei mentioned this pull request Jan 18, 2025
Closed
@marcalexiei

This comment was marked as resolved.

Sign in to view
@Valerioageno

This comment was marked as resolved.

Sign in to view
@jacobhq

This comment was marked as resolved.

Sign in to view
@jacobhq

This comment was marked as resolved.

Sign in to view
@marcalexiei marcalexiei changed the title chore: update documentation to tuono 0.17.1 chore: update documentation to tuono 0.17.x Jan 19, 2025
@marcalexiei

This comment was marked as resolved.

Sign in to view
@jacobhq

This comment was marked as resolved.

Sign in to view
@marcalexiei

This comment was marked as resolved.

Sign in to view
marcalexiei
marcalexiei reviewed Jan 20, 2025
View reviewed changes
Copy link
Member

@marcalexiei marcalexiei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this task.
Finally we can remove all react 18 dependencies from the project once completed!

I left a few points that need to be addressed though 😇

apps/documentation/package.json Outdated Show resolved Hide resolved
pnpm-lock.yaml Outdated Show resolved Hide resolved
apps/documentation/src/components/Breadcrumbs/Breadcrumbs.tsx Show resolved Hide resolved
@marcalexiei marcalexiei mentioned this pull request Jan 20, 2025
Closed
1 task
@jacobhq
Copy link
Contributor Author

jacobhq commented Jan 20, 2025

Alright, this PR is ready to merge if everything looks good :)

@Valerioageno Valerioageno merged commit 550830c into tuono-labs:main Jan 20, 2025
18 checks passed
@jacobhq jacobhq deleted the jm-bump-docs branch January 20, 2025 15:33
@marcalexiei marcalexiei mentioned this pull request Jan 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Valerioageno Valerioageno Valerioageno approved these changes

@marcalexiei marcalexiei marcalexiei approved these changes

Assignees

@jacobhq jacobhq

Labels
documentation Improvements or additions to documentation typescript Requires typescript knowledge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Documentation]: update documentation to tuono 0.17.x
3 participants
@jacobhq @Valerioageno @marcalexiei